Code Review sheet

Key:
Good
Acceptable
Unacceptable
N/A
Development Object Request ID:
Development Object Request Title:
Rev-Trac #
Transport #
Reviewer name:
Programmer:
Date:
Code review version:
Rework required:
Objects:

Naming Standards STANDARDS REVIEW COMMENTS

Report programs N/A

N/A
Module Pool Programs

N/A
Function Modules & Groups

N/A
Includes - Module Pool

N/A
Includes - Program

N/A
 N/A
Authorization objects

Batch Input Sessions N/A

SAPscript(Forms) N/A

N/A

SAPscript Print programs

N/A
Message Class

Area Menus N/A

Transaction N/A

Tables N/A

Table Index N/A

Acceptable

Domains N/A

Data Elements N/A

Fields N/A

Views N/A

Structure
N/A
Search helps Collective

N/A
Search helps Elemantary

N/A
Matchcode

Lock Objects N/A

 N/A

SAP Batch Jobs

Program Attributes STANDARDS REVIEW COMMENTS
Development Class N/A

N/A

Program type

Application area N/A

N/A
Authorization group

Description N/A

Documentation STANDARDS REVIEW COMMENTS

Proper program block heading N/A

Appropriate code documentation N/A

Standard Program Header N/A

Data Declaration STANDARDS REVIEW COMMENTS

Style
N/A
Technical attributes N/A
Parameters N/A

Select-options N/A

Ranges N/A

Internal Tables N/A

Structures N/A
Global variables N/A
Local variables (declared and used N/A
within a subroutine)
Indexes N/A
Contral variables N/A
Counters N/A
 N/A
Flag

Constants N/A
N/A
Types

Field Groups N/A

Field Symbols N/A

Data Declaration Names N/A

Correct occurs clause N/A

Selection Screen STANDARDS REVIEW COMMENTS

Appearance N/A

Appropriate defaults N/A

Appropriate validations N/A

Parameter ids N/A

Program Structure STANDARDS REVIEW COMMENTS
Correct event flow N/A
ABAP report programs (depends on object) N/A
N/A
 N/A
Forms STANDARDS REVIEW COMMENTS
Correct use of forms N/A
Documentation N/A
Form input / output parameters N/A

Coding Style STANDARDS REVIEW COMMENTS

Paper Size N/A

Comments N/A
INCLUDE N/A
SELECT (only commonly used)
USE AVOID REVIEW COMMENTS
Select with select list N/A

Select single N/A

Select with WHERE condition N/A

N/A

Select using an aggregate function N/A

Select into Table N/A

Array Insert N/A

Order By (if use of index) otherwise use N/A

SORT itab BY in an internal table
View or Internal Tables N/A

INTERNAL TABLE (only commonly used)

USE AVOID REVIEW COMMENTS
MOVE N/A

Sort with sort key specified explicitly N/A

Binary Search of an internal table N/A

APPEND N/A

Error Control STANDARDS REVIEW COMMENTS

Proper error control N/A

Appropriate error/success messages N/A

output
STANDARD INCLUDES STANDARD REVIEW COMMENTS
Use standard FM for Interface N/A
User standard FM for report N/A
Good